Expose the underlying channel from testutils.Channel

[easwars]

testutils.Channel provides a useful timed receive operation for tests.

There are some tests though where access to the underlying channel is required, because it is passed to some other component which receives on the channel. For example: readyCh in this test.

It would be nice to expose this underlying channel for tests that really need it. Something along the lines of timer.C would suffice.

[jackwener]

/assign

[jackwener]

Hi, I willing to take this task up.

[easwars]

Thanks.

[jackwener]

I'm not sure whether I got the right point of issue.
In order to expose the underlying channel, Is it enough that modify [ch](ch chan interface{}) into Ch?
I think that I may not understand correctly. Maybe I need some tips, thanks.

[easwars]

Yes, rename ch to C and add a comment, something to this effect

// C is the underlying channel on which values sent using the SendXxx() methods are delivered.
// Tests which cannot use ReceiveXxx() for whatever reasons can use C to read the values.

And also try to change the example test which I pointed to in the original description.

Hope this helps.

[jackwener]

And also try to change the example test which I pointed to in the original description.

The test should be changed, but it will be easy for me if the instruction and problem about test file is more clear.

[jackwener]

Maybe I get the point.
because underlying channel is't exposed, there aren't some tests.

grpc-go/xds/internal/server/listener_wrapper_test.go

Line 212 in 997ce61

_, readyCh, xdsC, _, cleanup := newListenerWrapper(t)

change into lw, readyCh, xdsC, lis, cleanup := newListenerWrapper(t)

And I should add some tests about underlying channel in xdsC and lis.

[uds5501]

Will be picking this one up once #4779 is resolved