Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: HTTP Filters on Client Side should be instantiated per Route #4639

Open
zasweq opened this issue Aug 3, 2021 · 1 comment
Open

xds: HTTP Filters on Client Side should be instantiated per Route #4639

zasweq opened this issue Aug 3, 2021 · 1 comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Performance Performance improvements (CPU, network, memory, etc)

Comments

@zasweq
Copy link
Contributor

zasweq commented Aug 3, 2021 •
edited
Loading

Currently, the ServiceConfig builds the list of HTTP Filters for each RPC. Rather than instantiate per RPC, we should do it once (per route), and run each RPC through the already instantiated filters once matched to a route.
@zasweq zasweq added the Type: Feature New features or improvements in behavior label Aug 3, 2021
@zasweq
Copy link
Contributor Author

zasweq commented Aug 3, 2021 •
edited
Loading

This is how C-Core treats it, except their API doesn't allow easy construction per each route, but what they do is instantiate the filter, send the instantiated filter the config override which acts as multiple knobs to turn for each RPC on the filter.

@zasweq zasweq changed the title HTTP Filters on Client Side should be instantiated once received xDS Config update HTTP Filters on Client Side should be instantiated per Route Aug 18, 2021
@easwars easwars added Type: Performance Performance improvements (CPU, network, memory, etc) P2 and removed Type: Feature New features or improvements in behavior labels Sep 8, 2021
@dfawley dfawley added the fixit label May 16, 2022
@dfawley dfawley self-assigned this May 16, 2022
@dfawley dfawley removed the fixit label Nov 28, 2022
@dfawley dfawley removed their assignment Nov 28, 2022
@purnesh42H purnesh42H added the Area: xDS Includes everything xDS related, including LB policies used with xDS. label Sep 8, 2024
@easwars easwars changed the title HTTP Filters on Client Side should be instantiated per Route xds: HTTP Filters on Client Side should be instantiated per Route Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Performance Performance improvements (CPU, network, memory, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@easwars @purnesh42H @dfawley @zasweq