-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
reflection: use protobuf/reflect instead of go reflection, fix dynamicpb
The reflection service panics when it encounters a dynamically-created message. The panic happens here: m, ok := reflect.Zero(reflect.PtrTo(st)).Interface().(protoMessage) This is because `st` is a `dynamicpb.Message` which can't be created using go reflection. Rather than add special handling for dynamic messages, migrating the reflection service to use protobuf/reflection instead of go reflection both solves the problem and cleans up a lot of code.
- Loading branch information
1 parent
5b37682
commit f11ad71
Showing
5 changed files
with
165 additions
and
120 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
syntax = "proto3"; | ||
|
||
package grpc.testing; | ||
|
||
message DynamicRes {} | ||
|
||
message DynamicReq {} | ||
|
||
service DynamicService { | ||
rpc DynamicMessage1(DynamicReq) returns (DynamicRes); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.