Improve grpc-dotnet debugging - #2192
Merged
Merged
Conversation
JamesNK
requested review from
BrennanConroy,
ReubenBond,
amcasey,
davidfowl and
mgravell
July 16, 2023 06:47
mgravell
approved these changes
Jul 16, 2023
mgravell
left a comment
mgravell
left a comment
Contributor
There was a problem hiding this comment.
Ignore previous comments: you'd already done what I suggested, I just misread the code
This was referenced Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR significantly improves the debugging experience of gRPC calls. Changes have been applied in many places. There are before and after screenshots of each.
ServerCallContext
Before:
After:
Server StreamReader
Before:
After:
Server StreamWriter
Before:
After:
Client call
Before:
After:
Client StreamReader
Before:
After:
Client StreamWriter
Before:
After:
Metadata
Before:
After: