Skip to content

Remove bad deadline test #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

Remove bad deadline test #1859

merged 1 commit into from
Aug 25, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 24, 2022 •
edited
Loading

  • Doesn't test anything useful. A deadline happening has no impact on accessing metadata.
  • Test has 1 second delay because there isn't a good async hook. Adds more time to running all tests.

@JamesNK JamesNK merged commit 0551be8 into grpc:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@brunolins16 brunolins16 Awaiting requested review from brunolins16

@captainsafia captainsafia Awaiting requested review from captainsafia

@halter73 halter73 Awaiting requested review from halter73

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesNK @BrennanConroy