Update dependencies; add pick_first; fix xds bug #22
Conversation
|
I'm not sure who owns this repo, but if I need to review this I'd like to request it to be split into 3 PRs. I'm not that familiar with the code, so seeing the independent parts of the change would be really helpful. I can "LGTM" the 1.22 |
|
I updated the PR to remove changes in cmd/xds.go - I will open another issue against this repo. Besides, PTAL. |
This happened in our repo because of our dependencies as well. We have also manually removed the patch version for the next release and will try to prevent it from happening in the future. |
| @@ -117,6 +117,7 @@ import ( | |||
| _ "github.com/envoyproxy/go-control-plane/envoy/extensions/internal_redirect/previous_routes/v3" | |||
| _ "github.com/envoyproxy/go-control-plane/envoy/extensions/internal_redirect/safe_cross_scheme/v3" | |||
| _ "github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/least_request/v3" | |||
| _ "github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/pick_first/v3" | |||
There was a problem hiding this comment.
Is there any kind of package in the root of go-control-plane somewhere we can import instead? This list is huge. :)
Or maybe we can generate the import list instead of maintaining it by hand?
There was a problem hiding this comment.
Thanks for the review!
- I can't find a common package that export all the stuff. I suspect even if that exists, it might just be a manual list maintained by go-control-plane so it really does not solve the issue.
- As for auto-generate, I am not sure what is the criteria for filtering. If I just filter by "*.pb.go" under
go-control-plane/envoy/there will be O(1000) of them; evengo-control-plane/envoy/extensionsgives me ~O(400). I am not sure if we need all of them.
I will open a separate issue to track this effort.
There was a problem hiding this comment.
What is the criteria for including in this binary?
Anyway, PR LGTM; I will merge it.
3. Allow xds to print more than 1 ClientConfig. When client is using RLS, it will receive an additional config for the RLS server.