-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update grpc from v1.16.0 to v1.17.0 #880
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 39 39
Lines 3913 3913
=======================================
Hits 2075 2075
Misses 1642 1642
Partials 196 196 Continue to review full report at Codecov.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
The gRPC project recently released 1.19.0 - why not go all the way? Could you try updating to 1.19.0 and see if we get any errors? |
Yes, I'll do it |
It's work |
Nice, thanks! I'll just need to confirm with @achew22 that this is still correct in Bazel land before merging. |
grpc is a dependency that gets managed by |
Update the grpc dependency to v1.17.0, which includes the fix
to remove the invalid github.com/golang/lint module requirement
in grpc/grpc-go#2393.
This change was generated by running the following commands
using Go 1.11: