Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bazel module dependencies #4974

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix Bazel module dependencies #4974

merged 1 commit into from
Nov 21, 2024

Conversation

AlejoAsd
Copy link
Contributor

References to other Issues or PRs

Fixes issue mentioned in PR comment.

Have you read the Contributing Guidelines?

Yes.

Brief description of what is fixed or changed

An explicit dependency to com_github_bazelbuild_buildtools_v7 has been added. This fixes issues when importing this downstream.

Other comments

@AlejoAsd AlejoAsd mentioned this pull request Nov 20, 2024
Merged
johanbrandhorst
johanbrandhorst approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix!

@johanbrandhorst johanbrandhorst merged commit a9901ae into grpc-ecosystem:main Nov 21, 2024
14 checks passed
@AlejoAsd AlejoAsd deleted the fix_bazel_module_deps branch November 21, 2024 20:13
@AlejoAsd AlejoAsd mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlejoAsd @johanbrandhorst