-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add expand_slashed_path_patterns flag #4813
Merged
johanbrandhorst
merged 11 commits into
grpc-ecosystem:main
from
czabaj:vg/4784-expand-slashed-path-patterns
Oct 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a1f0871
feat: add expand_slashed_path_patterns flag
czabaj 74da0f5
chore: improve comments
czabaj 692d9f9
chore: improve comments and code polishing
czabaj fc2b47b
fix: add expand_slashed_path_patterns into bazel
czabaj c1f25b6
refactor: extract logic to single function
czabaj 526aee9
refactor: expandPathPatterns fn don't mutate input
czabaj 745b0f2
fix: templateToParts camel-cases also path-patterns
czabaj 9a7d834
fix: inferred path-params not camel-cased
czabaj 7541b53
docs: document the new compiler option
czabaj 2e27ffc
fix: failing test
czabaj fd7ff1b
docs: reword documentation about the option
czabaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: templateToParts camel-cases also path-patterns
- Loading branch information
commit 745b0f214dd5b4aedc473ca6813e36a42454e374
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This second
jsonBuffer
was just a complexity gainer, I added a single branch to the}
case, where it extracts the parameter name and camel-case it, when the camel-casing is enabled.