Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #4762

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix typos #4762

merged 2 commits into from
Oct 4, 2024

Conversation

NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • reponse (7)
  • insenstive (5)
  • otional (4)
  • infront (4)
  • vversion (3)
  • expecte (2)
  • implmented (1)
  • intentionaly (1)
  • mesage (1)
  • direcly (1)
  • erorr (1)
  • expcted (1)
  • previouly (1)
  • provices (1)
  • spcifying (1)

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! This is very thorough 🤔.

@johanbrandhorst johanbrandhorst enabled auto-merge (squash) September 26, 2024 17:56
@NathanBaulch
Copy link
Contributor Author

No worries @johanbrandhorst, any idea why CI seems to be regenerating the typos?

@johanbrandhorst
Copy link
Collaborator

No worries @johanbrandhorst, any idea why CI seems to be regenerating the typos?

Looks like the files that have the typos now are part of the swagger-codegen generated files, so we can't do anything about them here (except maybe update our dependency). I would recommend you revert the changes to the configuration.go files.

auto-merge was automatically disabled October 3, 2024 05:35

Head branch was pushed to by a user without write access

@NathanBaulch
Copy link
Contributor Author

Ah, I see - https://github.com/swagger-api/swagger-codegen/blob/61cfeac3b9d855b4eb8bffa0d118bece117bcb7d/modules/swagger-codegen/src/main/resources/go/client.mustache#L104
Normally I'd upstream the fixes but I'm more of an openapi-generator kinda guy 😛

@johanbrandhorst johanbrandhorst merged commit 5469869 into grpc-ecosystem:main Oct 4, 2024
17 checks passed
@NathanBaulch NathanBaulch deleted the typos branch October 4, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants