stop printing error logs in handleForwardResponseOptions

[taichimaeda]

References to other Issues or PRs

Fixes: #4568

Have you read the Contributing Guidelines?

✅ Done

Brief description of what is fixed or changed

This will stop printing error messages when handleForwardResponseOptions fails, and instead wraps the error and lets the error handler deal with the printing, which should hopefully fix the issue around 304 status responses.

Other comments

My major concern is that DefaultHTTPErrorHandler seems to use the err only for getting the error status, and not for printing its message (correct me if I'm wrong) - will consider other solutions if this is not okay.

[johanbrandhorst]

LGTM!

[johanbrandhorst]

My major concern is that DefaultHTTPErrorHandler seems to use the err only for getting the error status, and not for printing its message (correct me if I'm wrong) - will consider other solutions if this is not okay.

I think this is fine, in effect all we've done is removed a log message and added some context to the error. I wouldn't consider it a breaking change.

[taichimaeda]

@johanbrandhorst

HI thanks for the merge!

I was just curious, would you think this change might take some time before getting rolled out in the next release?

If that's the case I might need to think of other temporary solutions, since it's getting somewhat urgent (the logs started overwhelming the metrics collector also...)

Never mind I've decided to just replace the commit hash in go.mod.