-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: output protobufAny definition using correct JSON schema #2292
Conversation
Just to help the reviewer, the only files I've changed is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change, thank you for your thorough testing and your patience!
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Just made a quick fix to the formatting of the test file :) |
Codecov Report
@@ Coverage Diff @@
## master #2292 +/- ##
==========================================
+ Coverage 59.16% 59.64% +0.47%
==========================================
Files 35 35
Lines 4484 4500 +16
==========================================
+ Hits 2653 2684 +31
+ Misses 1544 1525 -19
- Partials 287 291 +4
Continue to review full report at Codecov.
|
Thanks for your contribution! |
References to other Issues or PRs
Fixes #2177
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
Output the correct JSON schema for
google.protobuf.Any
as specified by the any.proto documentation.Other comments
Originally created PR #2180 but this wasn't the best approach. I've closed that and opened this since it made reviewing on top of out-of-date comments difficult.
I've made three separate commits which may make reviewing easier. I've added tests as the first commit which reproduces the issue.