Send trailers only when TE: trailers is set
#2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the code from the errors.go
zoido
changed the title
TE: trailers is set
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
==========================================
- Coverage 58.19% 58.09% -0.10%
==========================================
Files 35 35
Lines 3846 3852 +6
==========================================
Hits 2238 2238
- Misses 1338 1342 +4
- Partials 270 272 +2
Continue to review full report at Codecov.
|
adambabik
approved these changes
May 4, 2021
Also changed in the `testABELookupNotFound`
zoido
commented
May 5, 2021
|
Apologies for bothering. Are there any plans for this PR to be merged? Is there anything I should improve in order to enable the merge? |
Sorry this was delayed, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #1709
Have you read the Contributing Guidelines?
Yes.
Brief description of what is fixed or changed
Sends trailers back only when client specifies
TE: trailers.Other comments
I borrowed the code from
errors.gofrom #1499 as well as the approach to the tests.I was thinking about increasing the reuse but did not figure out anything elegant. Will gladly adjust.