Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding UnimplementedGreeterServer to server struct #1973

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

nwandabridges
Copy link
Contributor

The compiler produces an error without this. The error is:

cannot use &server literal (type *server) as type helloworld.GreeterServer in argument to helloworld.RegisterGreeterServer:
	*server does not implement helloworld.GreeterServer (missing helloworld.mustEmbedUnimplementedGreeterServer method)

References to other Issues or PRs

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

The compiler produces an error without this. The error is:

```
cannot use &server literal (type *server) as type helloworld.GreeterServer in argument to helloworld.RegisterGreeterServer:
	*server does not implement helloworld.GreeterServer (missing helloworld.mustEmbedUnimplementedGreeterServer method)
```
@google-cla google-cla bot added the cla: yes label Feb 16, 2021
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@johanbrandhorst johanbrandhorst merged commit bce65a9 into grpc-ecosystem:master Feb 16, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@nwandabridges nwandabridges deleted the patch-1 branch February 16, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants