Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/implement response headers v2 #1841

Merged
merged 20 commits into from
Nov 25, 2020
Merged

Feature/implement response headers v2 #1841

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
384bafa
Update v1 renovate config (#1738)
johanbrandhorst Oct 10, 2020
f6391fc
Update gorelease base for v1 (#1748)
johanbrandhorst Oct 14, 2020
2831fda
feat: protoc-gen-swagger: Implement Response Header(s) object, Implem…
elijah-roberts Oct 8, 2020
2a0e115
fix: resolve linting errors
elijah-roberts Oct 8, 2020
cfa0455
fix: running per CI
elijah-roberts Oct 8, 2020
dfa5c22
fix: Resolve PR requests
elijah-roberts Oct 8, 2020
f4ed5a6
fix: Running go mode tidy to cleanup go.mod and go.sum
elijah-roberts Oct 8, 2020
e615b55
fix: Resolving PR comments
elijah-roberts Oct 16, 2020
c943e16
Update protoc-gen-swagger/genswagger/template.go
elijah-roberts Oct 16, 2020
7672f81
Update protoc-gen-swagger/genswagger/template.go
elijah-roberts Oct 16, 2020
1cea661
fix: resolving MR requests
elijah-roberts Oct 22, 2020
5ef99d0
fix: unqouting error
elijah-roberts Oct 22, 2020
23275bf
Update protoc-gen-swagger/genswagger/template.go
elijah-roberts Oct 22, 2020
89d01c9
Update protoc-gen-swagger/genswagger/template.go
elijah-roberts Oct 22, 2020
9b22951
fix: adding requested changes
elijah-roberts Oct 22, 2020
968e362
Updating integer switch
elijah-roberts Oct 27, 2020
bbb50e6
Minor nits
johanbrandhorst Oct 28, 2020
9e9c879
Remove extra newlines
johanbrandhorst Oct 28, 2020
2079fa9
Updating for v2
elijah-roberts Nov 24, 2020
05b3e74
Pulling in changes for v2
elijah-roberts Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update protoc-gen-swagger/genswagger/template.go 
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
  • Loading branch information
@elijah-roberts @johanbrandhorst
elijah-roberts and johanbrandhorst authored Oct 22, 2020
commit 89d01c9bd6d1a1191af623edcfb8058b93bd2e79
2 changes: 1 addition & 1 deletion protoc-gen-swagger/genswagger/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,7 +1584,7 @@ func validateDefaultValueTypeAndFormat(headerType string, defaultValue string, f
}

func isQuotedString(s string) bool {
return len(s) >= 2 && string(s[0]) == `"` && string(s[len(s)-1]) == `"`
return len(s) >= 2 && s[0] == '"' && s[len(s)-1] == '"'
}

func isJSONNumber(s string, t string) error {
Expand Down