Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects an invalid test #1502

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Corrects an invalid test #1502

merged 1 commit into from
Jul 7, 2020

Conversation

yugui
Copy link
Member

@yugui yugui commented Jul 6, 2020

References to other Issues or PRs

Fixes #1501

Have you read the Contributing Guidelines?

Yes. I wrote it.

Brief description of what is fixed or changed

The expectations in the test was implemented wrong. But the wrong test
input has been hiding the wrong expectation, as explained in #1501.

Gave a non-zero size to dummyMarshaler to avoid the issue.

Other comments

@yugui yugui mentioned this pull request Jul 6, 2020
Closed
@yugui yugui requested a review from johanbrandhorst July 6, 2020 14:14
@yugui yugui force-pushed the fix/marshaler-registry-test branch from 8e11dff to 4ae8770 Compare July 6, 2020 14:16
johanbrandhorst
johanbrandhorst reviewed Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yugui, great so see you again 😄. Thanks for the fix, just a small grammatical nit on a comment.

runtime/marshaler_registry_test.go Outdated Show resolved Hide resolved
@yugui
Corrects an invalid test
593570d 
Fixes #1501.

The expectations in the test was implemented wrong. But the wrong test
input has been hiding the wrong expectation, as explained in #1501.
@yugui yugui force-pushed the fix/marshaler-registry-test branch from 4ae8770 to 593570d Compare July 6, 2020 20:15
@johanbrandhorst johanbrandhorst merged commit 18bdbc7 into master Jul 7, 2020
@johanbrandhorst johanbrandhorst deleted the fix/marshaler-registry-test branch July 7, 2020 10:02
@johanbrandhorst
Copy link
Collaborator

Thanks Yugui for the fix, could you please cherry pick this against the v2 branch as well?

yugui added a commit that referenced this pull request Jul 7, 2020
@yugui
Corrects an invalid test (#1502)
0022d96 
Fixes #1501.

The expectations in the test was implemented wrong. But the wrong test
input has been hiding the wrong expectation, as explained in #1501.
@yugui yugui mentioned this pull request Jul 7, 2020
Merged
johanbrandhorst pushed a commit that referenced this pull request Jul 7, 2020
@yugui
Corrects an invalid test (#1502) (#1509)
1ce9f28 
Fixes #1501.

The expectations in the test was implemented wrong. But the wrong test
input has been hiding the wrong expectation, as explained in #1501.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid test cases for runtime.Marshaler
3 participants
@yugui @johanbrandhorst @googlebot