Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 1398: deprecate Regiter_XXX_HandlerServer #1399

Merged
merged 6 commits into from
May 26, 2020
Merged

Fixes 1398: deprecate Regiter_XXX_HandlerServer #1399

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a29bec1
deprecate Regiter_XXX_HandlerServer
joesonw May 26, 2020
62cd49b
use Register_XXX_FromEndpoint instead
joesonw May 26, 2020
df88425
fix deprecated description and tests
joesonw May 26, 2020
6fd5e6c
fix verbal
joesonw May 26, 2020
30288cb
fix tests
joesonw May 26, 2020
924348b
change wording
joesonw May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deprecate Regiter_XXX_HandlerServer
  • Loading branch information
@joesonw
joesonw authored May 26, 2020
commit a29bec1dd10476748ed9990fc805a33e076add46
1 change: 1 addition & 0 deletions protoc-gen-grpc-gateway/internal/gengateway/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,7 @@ func local_request_{{.Method.Service.GetName}}_{{.Method.GetName}}_{{.Index}}(ct
// Register{{$svc.GetName}}{{$.RegisterFuncSuffix}}Server registers the http handlers for service {{$svc.GetName}} to "mux".
// UnaryRPC :call {{$svc.GetName}}Server directly.
// StreamingRPC :currently unsupported pending https://github.com/grpc/grpc-go/issues/906.
// Deprecated :use with caution. This will not provide grpc.ServerTransportStream https://github.com/grpc-ecosystem/grpc-gateway/issues/1398. This implementation will be missing certain features to behave like a standard stanalone grpc.Server.
func Register{{$svc.GetName}}{{$.RegisterFuncSuffix}}Server(ctx context.Context, mux *runtime.ServeMux, server {{$svc.GetName}}Server) error {
{{range $m := $svc.Methods}}
{{range $b := $m.Bindings}}
Expand Down