Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Pull Request Template for grpc-gateway #1366

Merged
merged 3 commits into from
May 19, 2020
Merged

added Pull Request Template for grpc-gateway #1366

merged 3 commits into from
May 19, 2020

Conversation

iamrajiv
Copy link
Contributor

added PULL_REQUEST_TEMPLATE.md file

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #1366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1366   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files          42       42           
  Lines        4375     4375           
=======================================
  Hits         2369     2369           
  Misses       1750     1750           
  Partials      256      256

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554b3da...f001ecf. Read the comment docs.

johanbrandhorst
johanbrandhorst approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

johanbrandhorst
johanbrandhorst requested changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one idea, could we move this under the .github directory to keep it out of the root?

@iamrajiv
Copy link
Contributor Author

sure @johanbrandhorst and I think ISSUE_TEMPLATE.md should also be moved to .github WDYT?

@johanbrandhorst
Copy link
Collaborator

sure @johanbrandhorst and I think ISSUE_TEMPLATE.md should also be moved to .github WDYT?

Great idea, please do!

@johanbrandhorst johanbrandhorst merged commit 050d8da into grpc-ecosystem:master May 19, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please cherry-pick this against v2?

@iamrajiv
Copy link
Contributor Author

sure @johanbrandhorst

This was referenced May 19, 2020
Closed
Merged
@iamrajiv iamrajiv deleted the pull_request_template branch May 20, 2020 21:51
@iamrajiv iamrajiv mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamrajiv @codecov-commenter @johanbrandhorst @googlebot