Improve comments, fix indentation and add new line #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone help why the generate build is failing when I add a new line |
Hi Aman, this is a generated file, so you don't want to change it because when we regenerate it later it would show a strange diff. Please revert that part of the PR. |
|
Hi @johanbrandhorst, I have reverted the changes. Thanks |
|
Thanks for your contribution! Could you cherry pick this against the v2 branch please? |
|
@johanbrandhorst, Do we always make two PRs, or should I only make PR for the v2 branch ? |
|
We need two PRs every time :). We haven't got a better system at the moment, since both branches need CLA approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT