-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix query params for invoked in-process local request #1212
fix query params for invoked in-process local request #1212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, could you add a test that would fail without this applied? We should have some tests for this local client somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rebase the changes on master? It should fix the build error.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
cbf6bc0
to
6e57b55
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
The bazel error still needs to be fixed manually: https://app.circleci.com/pipelines/github/grpc-ecosystem/grpc-gateway/174/workflows/618ded58-624f-42c6-9852-04d3427e0015/jobs/6796
|
Great work, thanks! Could you please open another PR to merge this to the v2 branch? |
* template query params bug * add test case for invoke in process gateway * fix bazel error
#939