fix(protoc-gen-swagger): Windows compatibility #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by protobuf.bzl from the main bazel repo: https://github.com/bazelbuild/bazel/blob/deeeba3fc8003cbbcc73e04f14fc5b5275e72e5d/third_party/protobuf/3.6.1/protobuf.bzl#L108 This PR introducing a windows mapping from protoc-gen-swagger to the binaries actual path.
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 42 42
Lines 4176 4176
=======================================
Hits 2249 2249
Misses 1681 1681
Partials 246 246Continue to review full report at Codecov.
|
johanbrandhorst
approved these changes
Oct 28, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by protobuf.bzl from the main bazel repo:
https://github.com/bazelbuild/bazel/blob/deeeba3fc8003cbbcc73e04f14fc5b5275e72e5d/third_party/protobuf/3.6.1/protobuf.bzl#L108
This PR introducing a windows mapping from protoc-gen-swagger to the binary's actual path.