third_party/googleapis is missing from package

[ggilley]

I'm installing the latest packages. third_party/googleapis is missing from the package:

$ ls github.com/grpc-ecosystem/grpc-gateway/       
LICENSE.txt             internal                protoc-gen-swagger      runtime                 utilities

So I can't compile anything because it depends on those files existing:

protoc -I/usr/local/include -I. \
  -I$GOPATH/src \
  -I$GOPATH/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \
  --ruby_out=. \
  path/to/your_service.proto

[johanbrandhorst]

Define "latest package" here? Is this in your vendor folder or something?

[ggilley]

What I mean is, I follow the instructions:

go get -u github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
go get -u github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
go get -u github.com/golang/protobuf/protoc-gen-go

And when I try to generate:

protoc -I/usr/local/include -I. \
  -I$GOPATH/src \
  -I$GOPATH/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \
  --go_out=plugins=grpc:. \
  path/to/your_service.proto

The /grpc-gateway/third_party/googleapis files do not exist.

[johanbrandhorst]

Yes these files are not tracked by go since they are proto files. The recommendation is to manually include them in your repository. Alternatively you can use bazel which solves most of this.

[ggilley]

Okay, then the instructions on the website need to be corrected. They don't mention this step at all and I wasted a bunch of time trying to figure out what I was doing wrong.

Plus, I think it's a silly decision since you can't use the grpc-gateway without them. Just makes everything harder for no reason.

[johanbrandhorst]

I'm sorry that the instructions were lacking in this case, would you be interested in contributing some better instructions to help the next person? I'd be happy to help you get a PR in.

As for this being a "silly decision", it's unfortunately out of our hands, there's no way to track proto files with go modules. Maybe you know a better way?

[ggilley]

Okay, I didn't realize it was a technical limitation. I'll investigate.

[BelarminoClearbanc]

The directory in question could be made into a package so that it would be vendored accordingly.
https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md

i.e. shomron/frameworks@5d5606f

[johanbrandhorst]

This is a very go-centric solution, and it is far from a standard approach to versioning protobuf. Unless it becomes more widespread in the community we're unlikely to follow this model.

[BelarminoClearbanc]

👍

[aviddiviner]

I was able to resolve this by doing:
-I=$GOPATH/pkg/mod/github.com/grpc-ecosystem/grpc-gateway@v1.12.1/third_party/googleapis

That version number will change depending on what you have installed.

[fresonn]

I had the same problem
I liked this solution: https://www.youtube.com/watch?v=Zf9G2KzYs7w
He just copied from "github.com/grpc-ecosystem/grpc-gateway@v1.14.6/third_party/googleapis/"
cp -r google ~/your_project_path

Works fine for me!

[jextrevor]

this is an ugly solution, and is turning me away from working with protobuf/grpc in general

[elchappo]

I have to admit is really hard to work with this sort of changes, each time I want to use it I have to invest time to fix it first :( pretty disappointed