Skip to content

Commit

Permalink
Merge remote-tracking branches 'mwitkow/bugfix/grpc-timeouts' and 'mi…
Browse files Browse the repository at this point in the history
…keatlas/remote-addr-context' into master

Also,
* Resolved conflicts
* Unified two proposed metadta names "RemoteAddr" and "X-Forwarded-For"
  into "X-Forwarded-For"
* Add error handlings
* Add more tests
* Replaced test values with the ones defined in RFC 5737
  • Loading branch information
yugui committed Jun 6, 2016
3 parents 2d6296e + d9d99f4 + 2732962 commit a5edb0b
Show file tree
Hide file tree
Showing 11 changed files with 611 additions and 133 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ More examples are available under `examples` directory.
* Mapping streaming APIs to JSON streams
* Mapping HTTP headers with `Grpc-Metadata-` prefix to gRPC metadata
* Optionally emitting API definition for [Swagger](http://swagger.io).
* Import path parameters compatible to protoc-gen-go.
* Setting [gRPC timeouts](http://www.grpc.io/docs/guides/wire.html) through inbound HTTP `Grpc-Timeout` header.
### Want to support
But not yet.
Expand Down
184 changes: 109 additions & 75 deletions examples/examplepb/a_bit_of_everything.pb.go

Large diffs are not rendered by default.

113 changes: 101 additions & 12 deletions examples/examplepb/a_bit_of_everything.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions examples/examplepb/a_bit_of_everything.proto
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,9 @@ service ABitOfEverythingService {
body: "*"
};
}
rpc Timeout(EmptyMessage) returns (EmptyMessage) {
option (google.api.http) = {
get: "/v2/example/timeout",
};
}
}
12 changes: 10 additions & 2 deletions examples/examplepb/echo_service.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a5edb0b

Please sign in to comment.