Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protovalidate: Add custom ErrorConverter #711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

protovalidate: Add custom ErrorConverter #711

wants to merge 1 commit into from

Conversation

khasanovbi
Copy link
Contributor

Changes

  • Fix validation for grpc stream, validate before message handling.
  • Add WithErrorConverter option to customize protovalidate output.

Verification

  • Add tests to related changes.
  • Check in my production.

@khasanovbi khasanovbi changed the title Add ErrorConverter to protovalidate protovalidate: Add custom ErrorConverter May 7, 2024
@khasanovbi khasanovbi mentioned this pull request May 7, 2024
Closed
@johanbrandhorst
Copy link
Collaborator

Hi, could you please open an issue first to discuss this change? I'm not sure I understand/agree that this is necessary. Thanks!

akshayjshah
akshayjshah reviewed May 25, 2024
View reviewed changes
interceptors/protovalidate/protovalidate.go
}

return nil
return w.ServerStream.RecvMsg(m)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? From what I can tell, RecvMsg is unmarshalling data into m, so we should validate after calling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khasanovbi @johanbrandhorst @akshayjshah