Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add partial per service auth override #708

Closed
wants to merge 1 commit into from
Closed

feat(auth): add partial per service auth override #708

wants to merge 1 commit into from

Conversation

seinshah
Copy link

closes #707

Changes

  1. Added public ErrNoAuthOverrideMatch to auth package
  2. Continue to run the provided AuthFunc when AuthFuncOverride returns ErrNoAuthOverrideMatch
  3. Added test cases

Verification

  • tested in my private project
  • added test case to ensure correctness when AuthFuncOverride returns ErrNoAuthOverrideMatch.

@johanbrandhorst
Copy link
Collaborator

Hi, thanks for the PR. Please don't submit PRs until we've agreed on a way forward to an issue.

@seinshah
Copy link
Author

@johanbrandhorst, in case of approving the issue, I wanted the issue to be on a fast track. It might be good to add this guideline to CONTRIBUTING.md file as well to prevent future cases. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Auth Interceptor: Add support for partial per service AuthFunc override
2 participants
@seinshah @johanbrandhorst