Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make test" and "make lint" ignore failures #626

Closed
olivierlemasle opened this issue Aug 28, 2023 · 0 comments · Fixed by #627
Closed

"make test" and "make lint" ignore failures #626

olivierlemasle opened this issue Aug 28, 2023 · 0 comments · Fixed by #627

Comments

@olivierlemasle
Copy link
Contributor

olivierlemasle commented Aug 28, 2023 •
edited
Loading

Currently (as of 99b851f), make test reports unit tests failure (in ./interceptors/logging), however the process ends with a success status (status code = 0).

CI should break, as long as the failing tests are not back to normal, but GitHub actions are succeeding.

Same thing for make lint, which should also break (PR #624 fixes linting errors).

Fixed in #627.
olivierlemasle added a commit to olivierlemasle/go-grpc-middleware that referenced this issue Aug 28, 2023
@olivierlemasle
Fix "make test" and "make lint"
97b13d0 
Fixes grpc-ecosystem#626
@olivierlemasle olivierlemasle mentioned this issue Aug 28, 2023
Merged
olivierlemasle added a commit to olivierlemasle/go-grpc-middleware that referenced this issue Aug 29, 2023
@olivierlemasle
Fix "make test" and "make lint"
abb9dac 
Fixes grpc-ecosystem#626
olivierlemasle added a commit to olivierlemasle/go-grpc-middleware that referenced this issue Aug 29, 2023
@olivierlemasle
Fix "make test" and "make lint"
0f730c3 
Fixes grpc-ecosystem#626
johanbrandhorst pushed a commit that referenced this issue Aug 29, 2023
@olivierlemasle
Fix "make test" and "make lint" (#627)
4679fb1 
* Fix "make test" and "make lint"

Fixes #626

* Fix failing unit test

In logging, policy for fields was reversed in 972f219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "make test" and "make lint" olivierlemasle/go-grpc-middleware
1 participant
@olivierlemasle