Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure androidid called once in a process #165

Merged
merged 4 commits into from
Jul 25, 2022
Merged

ensure androidid called once in a process #165

merged 4 commits into from
Jul 25, 2022

Conversation

cpacm
Copy link
Collaborator

@cpacm cpacm commented Jul 25, 2022

PR 内容

由于 Visit 中有直接调用 getAndroidId 的代码,若结果为空时会导致多次调用。
确保AndroidId方法只被调用一次。

测试步骤

测试 AndroidId 调用次数

影响范围

隐私合规

是否属于重要变动?

@cpacm cpacm requested review from styluo and tianhui12 July 25, 2022 03:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #165 (098fe70) into master (d81e5e8) will increase coverage by 0.42%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
+ Coverage     74.83%   75.25%   +0.42%     
- Complexity     1849     1861      +12     
============================================
  Files           207      207              
  Lines          7527     7534       +7     
  Branches        954      956       +2     
============================================
+ Hits           5633     5670      +37     
+ Misses         1297     1266      -31     
- Partials        597      598       +1     
Impacted Files Coverage Δ
...ndroid/sdk/track/providers/DeviceInfoProvider.java 77.61% <60.00%> (-2.39%) ⬇️
...m/growingio/android/debugger/WebSocketHandler.java 64.00% <0.00%> (-10.00%) ⬇️
...om/growingio/android/debugger/DebuggerService.java 67.04% <0.00%> (-2.28%) ⬇️
...m/growingio/android/database/EventDataManager.java 59.11% <0.00%> (-1.89%) ⬇️
...owingio/android/sdk/autotrack/view/ViewHelper.java 62.22% <0.00%> (-0.56%) ⬇️
...ingio/android/sdk/track/log/CircularFifoQueue.java 60.16% <0.00%> (+0.81%) ⬆️
...rowingio/android/database/DatabaseDataFetcher.java 62.50% <0.00%> (+2.08%) ⬆️
...io/android/sdk/track/webservices/log/WsLogger.java 82.14% <0.00%> (+7.14%) ⬆️
...m/growingio/android/sdk/track/log/CacheLogger.java 100.00% <0.00%> (+9.09%) ⬆️
...a/com/growingio/android/sdk/track/log/LogItem.java 92.00% <0.00%> (+12.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81e5e8...098fe70. Read the comment docs.

@cpacm cpacm merged commit ab7c82e into master Jul 25, 2022
@cpacm cpacm deleted the fix/androidid branch July 25, 2022 11:29
cpacm added a commit that referenced this pull request Jul 27, 2022
ensure androidid called once in a process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants