Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cascader group border #660

Merged
merged 6 commits into from
Dec 31, 2020
Merged

fix: cascader group border #660

merged 6 commits into from
Dec 31, 2020

Conversation

iahu
Copy link
Contributor

@iahu iahu commented Dec 30, 2020

  • cascader
    • group-name 改为 sticky 样式
    • aria-expanded 元素高亮
    • 拆分 less 文件
  • website
    • 修复 icons 名称问题

@vercel
Copy link

vercel bot commented Dec 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/4ec4wyezh
✅ Preview: https://gio-design-git-fork-iahu-fix-cascader-group-border.growingio.vercel.app

@iahu iahu changed the title fix cascader group border fix: cascader group border Dec 30, 2020
jack0pan and others added 3 commits December 30, 2020 13:56
affects: @gio-design/components, website
affects: @gio-design/components
affects: @gio-design/components

Co-authored-by: Jack <panjie@growingio.com>
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #660 (9b0e006) into master (f44a6ba) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   82.52%   82.57%   +0.04%     
==========================================
  Files         130      130              
  Lines        4384     4385       +1     
  Branches     1161     1160       -1     
==========================================
+ Hits         3618     3621       +3     
+ Misses        762      760       -2     
  Partials        4        4              
Impacted Files Coverage Δ
...components/src/components/cascader/single-menu.tsx 95.08% <100.00%> (+3.27%) ⬆️
...s/components/src/components/modal/CalloutModal.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44a6ba...faf12bd. Read the comment docs.

@iahu iahu requested a review from jack0pan December 30, 2020 06:15
@jack0pan jack0pan merged commit a681555 into growingio:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants