Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): invalid custom width #649

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Conversation

berber1016
Copy link
Contributor

affects: @gio-design/components, website

not set ref, the width will not take effect

当不设置ref时,设置width失效

ISSUES CLOSED: #647

@gio-design/package@version 20.12.4

  • Component
    • select

affects: @gio-design/components, website

not set ref, the width will not take effect

ISSUES CLOSED: growingio#647
@berber1016 berber1016 requested a review from zzt1224 as a code owner December 28, 2020 06:17
@vercel
Copy link

vercel bot commented Dec 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/gh1enmv4x
✅ Preview: https://gio-design-git-fork-berber1016-select.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #649 (069f6d1) into master (cba5052) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   82.51%   82.52%           
=======================================
  Files         130      130           
  Lines        4382     4384    +2     
  Branches     1160     1161    +1     
=======================================
+ Hits         3616     3618    +2     
  Misses        762      762           
  Partials        4        4           
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 91.44% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba5052...8e909a9. Read the comment docs.

@jack0pan jack0pan merged commit 6148e10 into growingio:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] 设置自定义宽度不生效
4 participants