Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): new feature allowClear #634

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Conversation

berber1016
Copy link
Contributor

@berber1016 berber1016 commented Dec 21, 2020

affects: @gio-design/components, website

ISSUES CLOSED: #604,#594

  • 新增allowClear参数,开启后拥有清除功能
  • 新增allowDeSelect参数,默认情况下不开启反选(multiple下该参数无效,开启后不执行 onDeselect)
  • 新增onClear方法 清除的回调
  • 支持ref参数

@vercel
Copy link

vercel bot commented Dec 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/1gc0909le
✅ Preview: https://gio-design-git-fork-berber1016-select.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #634 (b418477) into master (6af7df1) will decrease coverage by 0.13%.
The diff coverage is 68.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   82.65%   82.51%   -0.14%     
==========================================
  Files         130      130              
  Lines        4370     4382      +12     
  Branches     1152     1160       +8     
==========================================
+ Hits         3612     3616       +4     
- Misses        754      762       +8     
  Partials        4        4              
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 91.36% <54.54%> (-3.40%) ⬇️
.../components/src/components/table/FilterPopover.tsx 85.71% <75.00%> (ø)
packages/components/src/components/list/list.tsx 92.85% <100.00%> (+0.07%) ⬆️
packages/components/src/components/radio/Radio.tsx 100.00% <100.00%> (ø)
packages/components/src/components/table/Title.tsx 100.00% <100.00%> (ø)
...components/src/components/table/hook/useFilter.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4254b...a9fd080. Read the comment docs.

affects: @gio-design/components, website

ISSUES CLOSED: growingio#604,growingio#594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants