Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): fix style error width exceeds the parent element #633

Merged
merged 9 commits into from
Dec 25, 2020
Merged

fix(alert): fix style error width exceeds the parent element #633

merged 9 commits into from
Dec 25, 2020

Conversation

gavin-hao
Copy link
Contributor

…sizing:border-box
当 alert宽度100% ,因为存在padding,alert宽度会超出外层元素的宽度, gio-alert 设置样式 box-sizing:border-box;

@gio-design/package@version

  • Alert

@gio-design/package@version

  • Alert

@vercel
Copy link

vercel bot commented Dec 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/drg6zjt2h
✅ Preview: https://gio-design-git-fork-gavin-hao-master.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #633 (51daa5b) into master (2d4254b) will decrease coverage by 0.13%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   82.65%   82.51%   -0.14%     
==========================================
  Files         130      130              
  Lines        4371     4382      +11     
  Branches     1153     1160       +7     
==========================================
+ Hits         3613     3616       +3     
- Misses        754      762       +8     
  Partials        4        4              
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 91.36% <54.54%> (-3.40%) ⬇️
packages/components/src/components/list/list.tsx 92.85% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ecb02...0cba4b9. Read the comment docs.

@gavin-hao gavin-hao changed the title fix(alert):fix style error: width exceeds the parent element,set box-… fix(alert):fix style error: width exceeds the parent element Dec 22, 2020
…nt|当 alert宽度100% ,因为存在padding,a

affects: @gio-design/components
affects: @gio-design/components

fix style error: width exceeds the parent eleme…
@jack0pan jack0pan changed the title fix(alert):fix style error: width exceeds the parent element fix(alert):fix style error width exceeds the parent element Dec 25, 2020
@jack0pan jack0pan changed the title fix(alert):fix style error width exceeds the parent element fix(alert): fix style error width exceeds the parent element Dec 25, 2020
affects: @gio-design/components

当 alert宽度100% ,因为存在padding,alert宽度会超出外层元素的宽度, gio-alert 设置样式 box-sizing:border-box;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants