Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sign): add offset prop #623

Merged
merged 2 commits into from
Dec 17, 2020
Merged

feat(sign): add offset prop #623

merged 2 commits into from
Dec 17, 2020

Conversation

LEEHONCN
Copy link
Contributor

affects: @gio-design/components, website

@gio-design/components@20.12.2

  • 标记
    • 添加offset参数

@gio-design/components@20.12.2

  • Component 1
    • add offset prop

affects: @gio-design/components, website
@LEEHONCN LEEHONCN requested a review from phyzess December 17, 2020 03:20
@vercel
Copy link

vercel bot commented Dec 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/oydj0d9e0
✅ Preview: https://gio-design-git-sign-add.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #623 (1d8742e) into master (e9cca2b) will decrease coverage by 0.33%.
The diff coverage is 37.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   82.84%   82.51%   -0.34%     
==========================================
  Files         129      129              
  Lines        4262     4294      +32     
  Branches     1119     1134      +15     
==========================================
+ Hits         3531     3543      +12     
- Misses        728      747      +19     
- Partials        3        4       +1     
Impacted Files Coverage Δ
packages/components/src/components/sign/Number.tsx 60.00% <30.43%> (-40.00%) ⬇️
...mponents/src/components/date-picker/datePicker.tsx 63.63% <33.33%> (-0.52%) ⬇️
...nts/src/components/date-picker/dateRangePicker.tsx 57.89% <42.85%> (-0.68%) ⬇️
packages/components/src/components/sign/Sign.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d9dcd...a7b0efc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants