Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tabs, tab-nav): refactor tabs and tab-nav #601

Merged
merged 1 commit into from
Dec 10, 2020
Merged

refactor(tabs, tab-nav): refactor tabs and tab-nav #601

merged 1 commit into from
Dec 10, 2020

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Dec 9, 2020

affects: @gio-design/components, website

@gio-design/components@20.12.2

  • 标签导航,标签页
    • 重构标签导航和标签页
    • 去掉key的number 类型

@gio-design/components@20.12.2

  • tabs, tab-nav
    • refactor tabs and tab-nav
    • remove number type in key

@vercel
Copy link

vercel bot commented Dec 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/jl82x181n
✅ Preview: https://gio-design-git-tab-refactor.growingio.vercel.app

affects: @gio-design/components, website
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #601 (2b94671) into master (47fbb3c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   83.12%   83.07%   -0.05%     
==========================================
  Files         127      128       +1     
  Lines        4224     4230       +6     
  Branches     1117     1112       -5     
==========================================
+ Hits         3511     3514       +3     
- Misses        710      713       +3     
  Partials        3        3              
Impacted Files Coverage Δ
...kages/components/src/components/tab-nav/TabNav.tsx 94.11% <100.00%> (-5.89%) ⬇️
packages/components/src/components/tabs/Tabs.tsx 100.00% <100.00%> (ø)
...s/components/src/utils/hooks/useDeepCompareMemo.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fbb3c...1219318. Read the comment docs.

@jack0pan jack0pan self-assigned this Dec 10, 2020
@jack0pan jack0pan merged commit dfca0c4 into growingio:master Dec 10, 2020
jack0pan added a commit that referenced this pull request Dec 17, 2020
affects: @gio-design/components, website

Co-authored-by: Jack <panjie@growingio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants