Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): fix upload and remove action #591

Merged
merged 13 commits into from
Dec 8, 2020

Conversation

huqiyao
Copy link
Contributor

@huqiyao huqiyao commented Dec 7, 2020

affects: @gio-design/components

@gio-design/package

  • 组件 Upload
    • 为trigger接口增加onUpload属性,绑定点击上传事件
    • 修复有默认的file时,无法删除的问题

@gio-design/package

  • Component Upload
    • add onUpload prop
    • fix the problem that can not delete the default file

@huqiyao huqiyao requested a review from phyzess as a code owner December 7, 2020 06:55
@vercel
Copy link

vercel bot commented Dec 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/h2pxoamh6
✅ Preview: https://gio-design-git-fix-upload.growingio.vercel.app

affects: @gio-design/components
affects: @gio-design/components
affects: @gio-design/components
affects: @gio-design/components
affects: @gio-design/components
affects: @gio-design/components
affects: @gio-design/components
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #591 (065d16a) into master (cd445b9) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   83.21%   83.15%   -0.06%     
==========================================
  Files         126      126              
  Lines        4200     4204       +4     
  Branches     1109     1111       +2     
==========================================
+ Hits         3495     3496       +1     
- Misses        702      705       +3     
  Partials        3        3              
Impacted Files Coverage Δ
...ckages/components/src/components/upload/Upload.tsx 84.54% <0.00%> (-1.57%) ⬇️
...nts/src/components/upload/triggers/CardTrigger.tsx 90.00% <ø> (ø)
...kages/components/src/components/upload/Actions.tsx 100.00% <100.00%> (+3.84%) ⬆️
...ckages/components/src/components/cascader/menu.tsx 97.14% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93979b...bfc2b45. Read the comment docs.

affects: @gio-design/components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants