feat(select): 增加JSX方式添加Option #562

berber1016 · 2020-12-01T02:13:00Z

affects: @gio-design/components, website

@gio-design/components
Select
Numeric value, selector does not display the selected value
new feature clear
Select supports JSX to pass in Option

List
Option supports render method

vercel · 2020-12-01T02:13:05Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/1he2nlpdj
✅ Preview: https://gio-design-git-select.growingio.vercel.app

azure-pipelines · 2020-12-01T03:32:07Z

Deploy preview for gio-design failed.

azure-pipelines · 2020-12-01T05:28:57Z

Deploy preview for gio-design failed.

codecov · 2020-12-01T05:30:07Z

Codecov Report

Merging #562 (41f4095) into master (aa386e8) will increase coverage by 0.91%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   78.61%   79.52%   +0.91%     
==========================================
  Files         124      126       +2     
  Lines        4041     4084      +43     
  Branches     1062     1072      +10     
==========================================
+ Hits         3177     3248      +71     
+ Misses        857      830      -27     
+ Partials        7        6       -1

Impacted Files	Coverage Δ
...ckages/components/src/components/select/Select.tsx	`94.76% <90.00%> (-1.87%)`	⬇️
packages/components/src/components/list/list.tsx	`92.70% <100.00%> (+0.40%)`	⬆️
...ages/components/src/components/select/OptGroup.tsx	`100.00% <100.00%> (ø)`
...kages/components/src/components/select/Options.tsx	`100.00% <100.00%> (ø)`
...nts/src/components/date-picker/dateRangePicker.tsx	`59.21% <0.00%> (+43.42%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51666c...31927e6. Read the comment docs.

azure-pipelines · 2020-12-01T05:34:57Z

Deploy preview for gio-design failed.

azure-pipelines · 2020-12-01T05:50:31Z

Deploy preview for gio-design failed.

azure-pipelines · 2020-12-01T06:11:18Z

Deploy preview for gio-design failed.

azure-pipelines · 2020-12-01T06:51:30Z

Deploy preview for ready! ✅ https://deploy-preview-562--gio-design.surge.sh

zzt1224 · 2020-12-02T02:21:14Z

packages/components/src/components/list/style/option.less

@@ -2,7 +2,7 @@

 .@{select-prefix-cls}-option {
  max-width: 100%;
-  height: 40px;
+  // height: 40px;


不需要直接删除

zzt1224 · 2020-12-02T02:25:34Z

packages/components/src/components/select/index.tsx

@@ -1,5 +1,11 @@
 import Select from './Select';


这里需要和 #564 同步一下

azure-pipelines · 2020-12-02T03:02:00Z

Deploy preview for ready! ✅ https://deploy-preview-562--gio-design.surge.sh

azure-pipelines · 2020-12-02T12:06:24Z

Deploy preview for gio-design failed.

azure-pipelines · 2020-12-03T12:06:43Z

Deploy preview for gio-design failed.

affects: @gio-design/components, website ISSUES CLOSED: growingio#523, growingio#522, growingio#495, growingio#448

azure-pipelines · 2020-12-04T02:14:28Z

Deploy preview for ready! ✅ https://deploy-preview-562--gio-design.surge.sh

azure-pipelines · 2020-12-04T05:57:10Z

Deploy preview for ready! ✅ https://deploy-preview-562--gio-design.surge.sh

vercel bot deployed to Preview December 1, 2020 02:13 View deployment

berber1016 closed this Dec 1, 2020

jack0pan reopened this Dec 1, 2020

berber1016 force-pushed the select branch from 88f49b0 to ac93140 Compare December 1, 2020 03:26

vercel bot deployed to Preview December 1, 2020 03:26 View deployment

berber1016 requested a review from zzt1224 December 1, 2020 05:06

berber1016 force-pushed the select branch from ac93140 to 09f553a Compare December 1, 2020 05:23

vercel bot deployed to Preview December 1, 2020 05:23 View deployment

berber1016 force-pushed the select branch from 09f553a to f96234e Compare December 1, 2020 05:29

vercel bot deployed to Preview December 1, 2020 05:29 View deployment

berber1016 force-pushed the select branch from f96234e to 3068b72 Compare December 1, 2020 05:45

vercel bot deployed to Preview December 1, 2020 05:45 View deployment

berber1016 force-pushed the select branch from 3068b72 to 514f8da Compare December 1, 2020 06:00

vercel bot deployed to Preview December 1, 2020 06:00 View deployment

berber1016 force-pushed the select branch from 514f8da to 7e2e323 Compare December 1, 2020 06:43

vercel bot deployed to Preview December 1, 2020 06:43 View deployment

zzt1224 approved these changes Dec 2, 2020

View reviewed changes

berber1016 force-pushed the select branch from 7e2e323 to b3dcf4b Compare December 2, 2020 02:50

vercel bot had a problem deploying to Preview December 2, 2020 02:50 Failure

berber1016 force-pushed the select branch from b3dcf4b to 7456ff0 Compare December 2, 2020 02:52

vercel bot deployed to Preview December 2, 2020 02:52 View deployment

berber1016 force-pushed the select branch from 7456ff0 to e092242 Compare December 2, 2020 05:58

vercel bot deployed to Preview December 2, 2020 05:58 View deployment

berber1016 force-pushed the select branch from e092242 to 01da166 Compare December 2, 2020 06:04

vercel bot deployed to Preview December 2, 2020 06:04 View deployment

vercel bot had a problem deploying to Preview December 2, 2020 12:01 Failure

berber1016 force-pushed the select branch from 0595d1f to f37aa70 Compare December 3, 2020 12:02

vercel bot had a problem deploying to Preview December 3, 2020 12:02 Failure

feat(select): 增加JSX方式添加Option

4ac9b34

affects: @gio-design/components, website ISSUES CLOSED: growingio#523, growingio#522, growingio#495, growingio#448

berber1016 force-pushed the select branch from f37aa70 to 4ac9b34 Compare December 4, 2020 02:05

vercel bot deployed to Preview December 4, 2020 02:05 View deployment

Merge branch 'master' into select

0a27cbe

vercel bot deployed to Preview December 4, 2020 05:47 View deployment

jack0pan self-assigned this Dec 4, 2020

jack0pan added the add to next version label Dec 4, 2020

Merge branch 'master' into select

31927e6

vercel bot deployed to Preview December 4, 2020 12:37 View deployment

This was linked to issues Dec 4, 2020

[Select] 需要 clear 功能来清除输入内容 #448

Closed

[Select] 数值型value, selector不展示选中值 #495

Closed

[Select] Select支持jsx方式传入Option #522

Closed

jack0pan merged commit f819828 into growingio:master Dec 4, 2020

jack0pan removed the add to next version label Dec 8, 2020

zzt1224 linked an issue Dec 11, 2020 that may be closed by this pull request

[Select]空态时icon颜色不对 #497

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(select): 增加JSX方式添加Option #562

feat(select): 增加JSX方式添加Option #562

berber1016 commented Dec 1, 2020

vercel bot commented Dec 1, 2020 •

edited

Loading

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

codecov bot commented Dec 1, 2020 •

edited

Loading

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

zzt1224 Dec 2, 2020

zzt1224 Dec 2, 2020

azure-pipelines bot commented Dec 2, 2020

azure-pipelines bot commented Dec 2, 2020

azure-pipelines bot commented Dec 3, 2020

azure-pipelines bot commented Dec 4, 2020

azure-pipelines bot commented Dec 4, 2020

feat(select): 增加JSX方式添加Option #562

feat(select): 增加JSX方式添加Option #562

Conversation

berber1016 commented Dec 1, 2020

vercel bot commented Dec 1, 2020 • edited Loading

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

codecov bot commented Dec 1, 2020 • edited Loading

Codecov Report

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

azure-pipelines bot commented Dec 1, 2020

zzt1224 Dec 2, 2020

Choose a reason for hiding this comment

zzt1224 Dec 2, 2020

Choose a reason for hiding this comment

azure-pipelines bot commented Dec 2, 2020

azure-pipelines bot commented Dec 2, 2020

azure-pipelines bot commented Dec 3, 2020

azure-pipelines bot commented Dec 4, 2020

azure-pipelines bot commented Dec 4, 2020

vercel bot commented Dec 1, 2020 •

edited

Loading

codecov bot commented Dec 1, 2020 •

edited

Loading