Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search-bar): resolve some problems in search-bar #534

Merged
merged 4 commits into from
Nov 27, 2020
Merged

fix(search-bar): resolve some problems in search-bar #534

merged 4 commits into from
Nov 27, 2020

Conversation

WORLDI
Copy link
Contributor

@WORLDI WORLDI commented Nov 26, 2020

affects: @gio-design/components, website

resolve some problems in search-bar

@gio-design/components, website@20.11.3

  • 搜索框
    • 解决searchBar中图标垂直不居中的问题
    • 给searchBar组件的demo里加上placeholder
    • 处理searchBar中icon和边框间距的问题
    • 让id,value,onChange设置为可选
    • 搜索列表为空时,searchBar的focus不应该显示下拉框
    • 解决搜索框搜索列表显示逻辑错误的问题
    • 支持esc键退出列表
    • 差异化显示输入信息和建议信息之间的差异
    • 搜索列表中数据少于设定的条数时,让下拉列表的高度自适应

@gio-design/components, website@20.11.3

  • SearchBar
    • Solve the problem that the text Icon in searchBar is not centered vertically
    • Add a placeholder to the demo of the searchBar component
    • Dealing with the problem of icon and border spacing in searchBar
    • Set ID, value, onchange to optional
    • When the search list is empty, the search bar's focus should not display a drop-down box
    • Solve the problem of logic error in search box search list display
    • Support ESC key exit list
    • Differentiation shows the difference between input information and suggestion information
    • When the data in the search list is less than the set number, make the drop-down list highly adaptive

@vercel
Copy link

vercel bot commented Nov 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/fqp35knub
✅ Preview: https://gio-design-git-branchsearchbar.growingio.vercel.app

@WORLDI WORLDI linked an issue Nov 26, 2020 that may be closed by this pull request
@WORLDI WORLDI changed the title WIP(search-bar): resolve some problems in search-bar fix(search-bar): resolve some problems in search-bar Nov 26, 2020
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #534 (3453ca7) into master (8f1496f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files         124      124           
  Lines        4006     4007    +1     
  Branches     1043     1044    +1     
=======================================
+ Hits         3148     3149    +1     
  Misses        851      851           
  Partials        7        7           
Impacted Files Coverage Δ
...ckages/components/src/components/button/button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f090170...712a584. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@WORLDI WORLDI requested a review from LEEHONCN November 27, 2020 06:54
affects: @gio-design/components, website

resolve some problems in search-bar
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-534--gio-design.surge.sh

@huskylengcb huskylengcb merged commit 2d7708f into growingio:master Nov 27, 2020
@WORLDI WORLDI deleted the branch_searchBar branch December 22, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search Bar]组件中的id,value,onChange能不能不是必填
3 participants