Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): resolve tooltip in list and add placement prop #512

Merged
merged 3 commits into from
Nov 24, 2020
Merged

fix(list): resolve tooltip in list and add placement prop #512

merged 3 commits into from
Nov 24, 2020

Conversation

WORLDI
Copy link
Contributor

@WORLDI WORLDI commented Nov 24, 2020

affects: @gio-design/components

resolve tooltip in list and add placement prop

@gio-design/components@20.11.2

  • 列表
    • 解决tooltip被嵌套在list中的问题
    • 给list增加了placement参数,来控制tooltip的方向

@gio-design/components@20.11.2

  • List
    • Solve the problem that toolip is nested in the list
    • The placement parameter is added to the list to control the direction of the tooltip

@vercel
Copy link

vercel bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/9dk4gtjiy
✅ Preview: https://gio-design-git-tooltip.growingio.vercel.app

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #512 (b4e5e22) into master (fb2a80e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   78.46%   78.49%   +0.02%     
==========================================
  Files         122      122              
  Lines        3961     3966       +5     
  Branches     1030     1031       +1     
==========================================
+ Hits         3108     3113       +5     
  Misses        846      846              
  Partials        7        7              
Impacted Files Coverage Δ
packages/components/src/components/list/option.tsx 96.96% <ø> (ø)
packages/components/src/components/list/core.tsx 94.00% <100.00%> (+0.25%) ⬆️
packages/components/src/components/list/list.tsx 92.30% <100.00%> (+0.08%) ⬆️
packages/components/src/components/list/normal.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2a80e...7e71249. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-512--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-512--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-512--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

affects: @gio-design/components

resolve tooltip in list and add placement prop
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-512--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-512--gio-design.surge.sh

@huskylengcb huskylengcb merged commit 5244ab2 into growingio:master Nov 24, 2020
@WORLDI WORLDI deleted the tooltip branch December 1, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[List] tooltip内容过多时,整个tooltip被套在了List里面了
3 participants