Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dropdown): continue perfecting Dropdown demo #249

Merged
merged 1 commit into from
Sep 25, 2020
Merged

docs(dropdown): continue perfecting Dropdown demo #249

merged 1 commit into from
Sep 25, 2020

Conversation

LEEHONCN
Copy link
Contributor

affects: website

Changelog

Language Changelog
🇺🇸 English continue perfecting Dropdown demo
🇨🇳 Chinese 继续完善Dropdown Demo

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-249--gio-design.surge.sh

1 similar comment
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-249--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-249--gio-design.surge.sh

@Danny548326 Danny548326 requested a review from zzt1224 September 23, 2020 05:57
inputWrapStyle={{ width: 208, margin: '16px 16px 8px' }}
/>
<List
dataSource={options}
dataSource={options.filter((option) => option.label.includes(searchvalue))}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以用memo包一下

inputWrapStyle={{ width: 288, margin: '16px 16px 8px' }}
/>
<List dataSource={options} width={320} height={358} />
<List dataSource={options.filter((option) => option.label.includes(searchvalue))} width={320} height={280} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo

@Danny548326 Danny548326 merged commit 9ca1965 into growingio:master Sep 25, 2020
@LEEHONCN LEEHONCN deleted the Dropdown-demo branch November 4, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants