Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepmodal): fix stepmodal footer logic error; fix update steps props error #226

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Sep 16, 2020

affects: @gio-design/components

fix stepmodal footer logic error; fix update steps props error

ISSUES CLOSED: #211

Related issue link

#211

Changelog

fix stepmodal footer logic error.
unset footer should display default footer.
fix update steps props error, add wayout prop.

Language Changelog
🇺🇸 English fix stepmodal footer logic error. fix update steps props error. add wayout prop to fix step path.
🇨🇳 Chinese 修复分步骤弹窗组件footer显示逻辑。修复steps props 变更造成崩溃的问题。修复steps路径不能满足某些情况的问题。

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components

fix stepmodal footer logic error; fix update steps props error

ISSUES CLOSED: #211
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #226 into master will decrease coverage by 0.06%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   70.02%   69.96%   -0.07%     
==========================================
  Files          90       90              
  Lines        2392     2397       +5     
  Branches      611      610       -1     
==========================================
+ Hits         1675     1677       +2     
- Misses        713      716       +3     
  Partials        4        4              
Impacted Files Coverage Δ
...ages/components/src/components/modal/StepModal.tsx 72.05% <83.33%> (-0.08%) ⬇️
packages/components/src/components/modal/Modal.tsx 98.07% <100.00%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b29146...3aafede. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-226--gio-design.surge.sh

@LEEHONCN LEEHONCN requested a review from phyzess September 16, 2020 09:45
@phyzess phyzess merged commit 8cdcbcd into growingio:master Sep 16, 2020
@LEEHONCN LEEHONCN deleted the modal-fix branch September 17, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StepModal footer logic error and when steps props update will occur error
2 participants