Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): add forwardRef for input and textarea #197

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

1eeing
Copy link
Contributor

@1eeing 1eeing commented Sep 9, 2020

affects: @gio-design/components

ISSUES CLOSED: #179

Related issue link

Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components

ISSUES CLOSED: growingio#179
@1eeing 1eeing requested review from LEEHONCN and zzt1224 September 9, 2020 04:54
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #197 into master will increase coverage by 0.53%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   70.68%   71.21%   +0.53%     
==========================================
  Files          77       78       +1     
  Lines        1968     2001      +33     
  Branches      514      518       +4     
==========================================
+ Hits         1391     1425      +34     
+ Misses        572      571       -1     
  Partials        5        5              
Impacted Files Coverage Δ
packages/components/src/components/alert/alert.tsx 0.00% <0.00%> (ø)
...es/components/src/components/checkbox/checkbox.tsx 100.00% <ø> (ø)
packages/components/src/components/modal/Modal.tsx 0.00% <ø> (ø)
...es/components/src/components/tooltip/placements.ts 90.47% <ø> (ø)
packages/components/src/components/tree/Tree.tsx 0.00% <0.00%> (ø)
...ckages/components/src/components/tree/iconUtil.tsx 0.00% <0.00%> (ø)
...s/components/src/utils/hooks/useDebounceLoading.ts 100.00% <ø> (ø)
packages/components/src/utils/hooks/useRefs.tsx 100.00% <ø> (ø)
packages/components/src/utils/hooks/useToggle.ts 0.00% <0.00%> (ø)
...s/src/components/table/hook/useEllipsisTooltip.tsx 57.14% <35.71%> (-1.95%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5307cf...335eaa2. Read the comment docs.

@1eeing 1eeing requested review from itiiss and removed request for LEEHONCN September 9, 2020 04:58
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@1eeing 1eeing merged commit 5f1a6d1 into growingio:master Sep 9, 2020
@jack0pan jack0pan added add to next version 🐛 bug Something isn't working and removed add to next version labels Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input组件 ref参数
4 participants