Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website,tokens,icons,components): 修改button的一些问题 #174

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

huskylengcb
Copy link
Contributor

@huskylengcb huskylengcb commented Aug 31, 2020

affects: @gio-design/components, @gio-design/icons, @gio-design/tokens, website

Related issue link

Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-174--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #174 into master will increase coverage by 0.81%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   64.24%   65.06%   +0.81%     
==========================================
  Files          76       74       -2     
  Lines        1972     1932      -40     
  Branches      515      504      -11     
==========================================
- Hits         1267     1257      -10     
+ Misses        700      670      -30     
  Partials        5        5              
Impacted Files Coverage Δ
...ts/src/components/upload/triggers/InputTrigger.tsx 84.61% <66.66%> (ø)
...ckages/components/src/components/button/button.tsx 89.15% <100.00%> (-0.26%) ⬇️
packages/components/src/utils/hooks/useHover.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac5b73...41d9027. Read the comment docs.

@jack0pan jack0pan self-assigned this Aug 31, 2020
@jack0pan jack0pan requested review from phyzess, LEEHONCN and jack0pan and removed request for phyzess August 31, 2020 11:36
Copy link
Member

@jack0pan jack0pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoadingWhiteOutlined.tsxLoadingWhiteOutlined.tsx 两个文件删除吧,删 svg 文件不会同步的删 tsx 文件。

@jack0pan jack0pan linked an issue Aug 31, 2020 that may be closed by this pull request
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-174--gio-design.surge.sh

affects: @gio-design/components, @gio-design/icons, @gio-design/tokens, website
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-174--gio-design.surge.sh

@jack0pan jack0pan merged commit 3e0f03e into growingio:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

按钮组件相关问题
2 participants