fix(select): clear missing (#1825)

Co-authored-by: maxin <maxin@growingio.com>
growingio · Jan 25, 2022 · a353ac6 · a353ac6 · vercel · Jan 25, 2022
1 parent 422687e
commit a353ac6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/input/InputButton.tsx b/src/input/InputButton.tsx
@@ -86,7 +86,7 @@ const InputButton = React.forwardRef<HTMLInputElement, InputButtonProps>((props,
       className={classNames(inputCls, wrapperCls)}
       type="button"
       // when set Input type=button, the placeholder is invalid
-      value={value || placeholder}
+      value={value ?? placeholder}
       title={value as string}
       onChange={onChange}
       prefix={customizePrefix}

diff --git a/src/select/Select.tsx b/src/select/Select.tsx
@@ -78,6 +78,7 @@ const Select: React.FC<SelectProps> & { isSelect?: boolean } = (props) => {
   const handleOnClear = (e: React.MouseEvent<Element, MouseEvent>) => {
     onClear?.();
     onChange?.();
+    setValue('');
     handVisibleChange(false);
     e.stopPropagation();
   };