fix: Pages eligible for migration are not displayed when accessing private legacy pages #10571
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
commented
Dec 5, 2025
| // biome-ignore lint/style/noRestrictedImports: no-problem dynamic import | ||
| () => import('~/features/search/client/components/PrivateLegacyPages'), | ||
| { ssr: false }, | ||
| ); |
Member
Author
There was a problem hiding this comment.
NextPage の中で dynamic import していたのでリレンダリングのたびに flickering していた
miya
commented
Dec 5, 2025
| // biome-ignore lint/correctness/useExhaustiveDependencies: only run on mount | ||
| useEffect(() => { | ||
| setSearchKeyword(initQ); | ||
| }, []); |
Member
Author
There was a problem hiding this comment.
バグの原因
useSearchKeyword() の初期値である "" (空文字列) で検索していたことにより、マイグレーション対象のページが表示されていなかった。
修正方法
master の仕様と合わせて /_private-legacy-pages にアクセスしたタイミングで '/' の検索結果を表示するように改修。
NextPage で atom を "/" で hydrate することも考えたが、useSetSearchKeyword を使って値を更新することで SSoT を実現しているので atom を直接書き換えることはせず CSR 後に useEffect の中で useSetSearchKeyword を実行するようにしている。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
https://redmine.weseek.co.jp/issues/174633