Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for the stdweb backend in the hello example. #61

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Instructions for the stdweb backend in the hello example. #61

merged 1 commit into from
Nov 22, 2019

Conversation

theypsilon
Copy link
Contributor

Previously there weren't instructions to run the 'hello' example on stdweb, so I'm adding them.

But I also noticed that the README.md is not quite right yet. The web-sys backend instructions seem obsolete, but I can't find and easy way to make it work with wasm-pack because 'hello' is a binary crate.

Here is a pull request to make wasm-pack compatible with binary crates: rustwasm/wasm-pack#736

Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

The web-sys instructions should work fine, I just used them last night to build for web-sys. Please create an issue or let me know which part doesn't work for you

bors r+

bors bot added a commit that referenced this pull request Nov 22, 2019
61: Instructions for the stdweb backend in the hello example. r=grovesNL a=theypsilon

Previously there weren't instructions to run the 'hello' example on stdweb, so I'm adding them.

But I also noticed that the README.md is not quite right yet. The web-sys backend instructions seem obsolete, but I can't find and easy way to make it work with wasm-pack because 'hello' is a binary crate.

Here is a pull request to make wasm-pack compatible with binary crates: rustwasm/wasm-pack#736

Co-authored-by: José manuel Barroso Galindo <theypsilon@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2019

Build succeeded

@bors bors bot merged commit c0e5d2d into grovesNL:master Nov 22, 2019
@theypsilon
Copy link
Contributor Author

theypsilon commented Nov 23, 2019

👍 Thank you!

The web-sys instructions should work fine, I just used them last night to build for web-sys. Please create an issue or let me know which part doesn't work for you

bors r+

I think for you is working because you have installed wasm-bindgen cli from some time ago. But as of now, it's not possible to install it from cargo install. If you read the docs from wasm-bindgen, they now ask you to use wasm-pack instead.

@grovesNL
Copy link
Owner

You can install the latest wasm-bindgen-cli with cargo install wasm-bindgen-cli --force

@theypsilon
Copy link
Contributor Author

Welp, I guessed wrong, I was trying to install it without the postfix. Thanks man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants