Fill out tex*Image*D overloads for WebGL2 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
grovesNL
reviewed
Dec 18, 2022
There was a problem hiding this comment.
Thank you! This looks great but I think we should probably split up tex_sub_image_2d_with_image_bitmap into two functions or accept width and height as Option<i32> instead of silently ignoring those parameters on WebGL1.
Even on WebGL2 there might be some benefits to making width and height optional.
|
Alright, I'll split them |
cwfitzgerald
force-pushed
the
webgl2-teximage
branch
from
843c2e4
to
bbc8a89
Compare
cwfitzgerald
force-pushed
the
webgl2-teximage
branch
from
bbc8a89
to
0ab1b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fills out the various gl web apis for texImageD overloads with Canvas, Video, Image, and ImageBitmap.
In service of gfx-rs/wgpu#1888.
The other major change is adding width and height arguments to the ones that are shared with webgl1 - it will just ignore the width and height on webgl1.