Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Bug fixing/fix safari edge max instancesto1 #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarwaOuledElHadjAli
Copy link

Safari and Edge maxInstances should be equals to 1

Safari MaxInstances should be 1
Edge MaxInstances should be 1
@glacier6327
Copy link

@MarwaOuledElHadjAli are you able to use this project? Our group used it a few years ago and we loved it, but I see no code changes in almost two years... Also : @dimacus @smccarthy

@byamagata
Copy link

@glacier6327 I can confirm that my company still uses this project. It has its issues, but we make up for it with proprietary software that helps with cleanup, management, etc. Basically I have written a wrapper around it that makes sure things are taken care of. Why do you ask?

@chamiz
Copy link

chamiz commented Feb 3, 2021

@MarwaOuledElHadjAli What is the reason for setting maximum instances to 1? Is this change applicable for old Edge or Edge Chromium?

@MarwaOuledElHadjAli
Copy link
Author

@MarwaOuledElHadjAli What is the reason for setting maximum instances to 1? Is this change applicable for old Edge or Edge Chromium?

If instances are more than 1 ==> test fails

@chamiz
Copy link

chamiz commented Feb 3, 2021

Oh. Thanks for the tip. This for Edge legacy right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants