Banhammer: add /mute command, issue #343 #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangm97
requested changes
Sep 1, 2018
Member
yangm97
left a comment
yangm97
left a comment
There was a problem hiding this comment.
Besides review comments, there should be some (a lot) of merge conflicts to solve, but I'd be glad to merge it once everything is sorted out since it's a very requested feature.
| end | ||
|
|
||
| function api.muteUser(chat_id, user_id) | ||
| function api.muteUser(chat_id, user_id, until_date) |
Member
There was a problem hiding this comment.
This function has been moved to utilities.lua
| return markup | ||
| end | ||
|
|
||
| local function markup_mute(chat_id, user_id, time_value) |
Member
There was a problem hiding this comment.
Would've been better if you could reuse the keyboard for tempban instead of copy-pasting it's code.
|
|
||
| function plugin.onCallbackQuery(msg, matches) | ||
| if not u.can(msg.chat.id, msg.from.id, 'can_restrict_members') then | ||
| if not u.is_allowed('hammer', msg.chat.id, msg.from) then |
Member
There was a problem hiding this comment.
Why did you replace the new permission check with the dummy one?
| end | ||
| if not res then | ||
| motivation = motivation or i18n("I can't kick this user.\n" | ||
| motivation = i18n("I can't kick this user.\n" |
Member
There was a problem hiding this comment.
You could just use the new api_err.trans() function.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.