[WIP] Issue 30 - Overhauled data structure #84
Conversation
| @@ -61,7 +61,8 @@ def add_stops_to_schedule(self, schedule, data): | |||
| stops = data.get_stops() | |||
| stops_by_name = {} | |||
|
|
|||
| for a_stop in stops.values(): | |||
| for a_stop_id, a_stop in stops.items(): | |||
There was a problem hiding this comment.
@xamanu your patch on the Accra creator is not ok : it alters the structure of the GTFS stop_id.
Can you help me to fix it, please?
My problem is that on my local machine, Accra is not going through (with the master branch).
With the new structure it threw the error of not getting the osm_id, with the fix it gets it and again the same error is presented to me, as with the old structure. Probably I'm not seeing the whole picture and I would kindly ask to for your support on this particular issue. Thanks a lot!
There was a problem hiding this comment.
Sure !
What is your error message in the master branch ?
Did you refresh the cache to change the data structure ?
With your fix, the stop_id (in the generated stops.txt file) looks like node/5025827612 whereas it was looking like 5025827612 in the master branch.
I did not find yet why, but no stop_times.txt and frequencies.txt are generated in the current branch.
There was a problem hiding this comment.
I have to check it again. Will do and report.
Regarding the stop name: In osm2gtfs we thought using the format "node/OSM_ID" and "way/OSM_ID" because there can be stops marked as points but also as polygon (Think about the whole bus shelter). But this is only the internal handling of osm2gtfs. Of course the stop_id can be set to anything, what you prefer, but this should happen inside the special city implementation.
There was a problem hiding this comment.
Yep, I do agree : "node/OSM_ID" is a better format for stop_id than "OSM_ID" alone.
But Accra GTFS data is already in use, so we cannot change all the stop_id ...
This is already done in the Accra trip creator : https://github.com/xamanu/osm2gtfs/blob/f09f2857d2d1911428203e7a9260a3d10a391044/osm2gtfs/creators/accra/trips_creator_accra.py#L76
|
@xamanu I tried to run Accra tests on this branch, but I have some troubles ...
|
Thanks for testing the branch and working on it! Actually I'm working on it, too, and as such the changes shown here are a little bit outdated. I did not find the time to upstream everything yet and therefore all changes are in a large messy branch creators-nicaragua, but I will start upstreaming the changes in atomic pull requests next week.
Yeah, I also noticed this but did not find the reason yet. I'll investigate this today.
For me this actually worked, but I'll try to help you when I finished with the Nicaraguan work. |
OK, learned another thing about Python:
Source: https://stackoverflow.com/a/10085764 Sorry for the inconveniences. |
AltNico
changed the title
|
Closing as there has been a lot of things happening in https://github.com/mapanica/osm2gtfs |
Follow up to PR #70
Asked to be re-requested by @AltNico in https://github.com/AltNico/osm2gtfs/pull/1