default stops creator #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@xirapo is working on a stops_creator for the irtramma network, which is exactly as the one of fenix and incofer. This default stops_creator could make the job. |
|
Good point! We should get this merged eventually. I hope I'll find time soon to make sure this doesn't break the fenix creator. |
Merged
grote
approved these changes
Sep 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that stops creator input data comes from OSM, makes sense to have a default stops creator. By the way, I didn't notice that with the latest changes I did to incofer stops creator, it results to be equal to the fenix stops creator 😉 .
This will make the code easier to mantain. I prefer to merge this before creating a PR for issue #55.