-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to maplibre v10 and jawg.io #880
Conversation
If anybody gave this a test-run, please comment here. |
If anyone could upload a precompiled APK that would likely ease testing… |
I build a apk on commit a9d4ffa: |
Thanks to @wallalex0's build, I can confirm that Transportr is fully functional with this PR, including the device's location over GPS (I do not have Google Play Services installed anyway, so this is all GNSS). The biggest difference you notice between this version and the latest release, is that this version's map is fully greyscale. I'm not sure if this is in an intentional change or rather a technical limitation. Personally I think the colour map is prettier, but a greyscale map is more useful, since it shows only the important details (i.e. the trip and stations), with other details fading into the background. I know one test report won't seal the deal for you, but, if this were my project, I would definitely merge this as soon as possible, and get Transportr back in F-Droid as soon as possible. It's a great app, with some unique features on Android (neither the DB or SBB apps have any map of the trip for example), and it's only going to get better. But, this PR, and the subsequent return to F-Droid, is a necessary first step. (Maybe then @ialokim's SBB support can also be merged. Seems like schildbach/public-transport-enabler#481 is the holdup. Once merged, Transportr will be the only open source app in existence to support SBB!) |
Also tested it and I can also agree:
|
That's a very good point, I had forgotten about this change (dark theme user here). Here's how the difference looks in practice There are more default map styles available from jawg.io, including On the other hand, the used |
I would still switch to |
I also gave this a test run in my daily travels the last days and everything seems to work as expected. Thanks for the work! |
This should enable us to get back into the main F-Droid repo eventually.
I would appreciate some testing by others before this is merged, especially concerning the device's location (GPS).